[Wayland-bugs] [Bug 81819] New: Xwayland crashes when seat adds a capability and sends some input event

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=81819

          Priority: medium
            Bug ID: 81819
          Assignee: wayland-bugs at lists.freedesktop.org
           Summary: Xwayland crashes when seat adds a capability and sends
                    some input event
        QA Contact: xorg-team at lists.x.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: mforney at mforney.org
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: XWayland
           Product: Wayland

When Xwayland is started while the seat has limited capabilities (i.e. only
pointer) and then later on more capabilities are added, any events sent from
those new devices cause a crash.

This seems to be because in xwayland-input.c:add_device where the devices are
created, xwayland adds them with AddInputDevice, but does not activate or
enable them (with ActivateDevice and EnableDevice), so
miPointerDeviceInitialize is never called on these devices.

The devices with the capabilities present when Xwayland starts do not have this
problem because they are activated and enabled in InitAndStartDevices.

I think adding a call to ActivateDevice, followed by a call to EnableDevice at
the end of add_device should be enough (and it does solve the problem), but I
am not familiar enough with the X server architecture to know if this is the
right solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140727/2bb501f9/attachment.html>