[Wayland-bugs] [Bug 80273] SIGSEGV in weston_wm_window_destroy

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80273

--- Comment #2 from Pekka Paalanen <ppaalanen at gmail.com> ---
(In reply to comment #1)
> Possible Fixes:
> 
> 2. Add NULL pointer checks to wl_list_remove in Wayland's source at
> wayland-util.c:52. This would work, but it sort of acts like a band-aid for
> the real problem, which is in Weston. One could argue that wayland shouldn't
> crash due to the negligence of the display compositor, but the C++ STL is
> like wayland in that it will crash or leak memory if improperly managed.

Yeah, at least this option 2 is invalid. wl_list functions assume that they are
always used right: a double-remove is illegal. Even the set-to-NULL here is
only a debug aid to make sure the program crashes rather than silently corrupts
memory. Also checking for wl_list::next/prev for NULL is invalid if expected to
be set by libwayland.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140630/5427ee29/attachment.html>