[Wayland-bugs] [Bug 735831] Change current cursor on grabs

[gtk+ (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735831
  gtk+ | Backend: Wayland | unspecified

--- Comment #5 from Carlos Garnacho <carlosg at gnome.org> 2014-09-01 18:44:12 UTC ---
(In reply to comment #3)
> Review of attachment 285043 [details]:
> 
> The problem with allowing animation is that we don't know when to stop the
> animation ?
> Anyway, looks good so far

The GdkWaylandDeviceData also stores a cursor_image_index for the window
cursor, so it knows the "frame" it's in, I'd have to replicate that for the
grab cursor, which wasn't too clean. I think a better fix would be to store
that into GdkWaylandCursor instead, and have a gdk_wayland_cursor_tick() call
that bumps the current cursor frame, that way both cursors could be animatable.

(In reply to comment #4)
> Review of attachment 285042 [details]:
> 
> if we can't trust leave to actually mean leave, we have a problem with knowing
> when to stop the cursor animation, I guess ?

I at the moment made it so the animation is stopped inconditionally, you either
truly leave the window, or get a different cursor used instead with the other
patch. If cursor animation is always made to run dependent on the currently set
cursor, and cursors are reset to their first frame when going unused, I think
that should make the timer run whenever really necessary, and all cursor
animations look consistent.

Anyway, all of this is probably better tackled separately.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.