[Wayland-bugs] [Bug 83304] wl_display_roundtrip() seems not thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=83304

--- Comment #3 from Remi Denis-Courmont <courmisch at gmail.com> ---
Pekka, the mainloop is simplistic and tries to follow the documentation:
https://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/wl/shell_surface.c;hb=2.2.0-git-662-ge08f4fc#l48

(Admittedly the cleanup path may look unorthodox, but you can ignore it as the
deadlock predates it.) The deadlock is there, right below FIXME:

https://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/wl/shm.c;hb=2.2.0-git-662-ge08f4fc#l184

(NOTE: I know that wl_shm is not the best option for media playback. In the
long term, we definitely want to avoid software scaling and colour space
conversion. But that is outside the scope of this bug.)

I tried to use wl_event_queue, but it gave me crashes in the mainloop after
destroying the supposedly no longer used queue. I guess I don't know how/when
it is safe to delete a queue.

So it does not seem to me that "it all works if all threads follow the polling
protocol documented".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140901/d8cc5b15/attachment.html>