[Wayland-bugs] [Bug 744932] Wrong (ultra tiny/small) cursor size on HiDPI screen

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744932

--- Comment #21 from Owen Taylor <otaylor at redhat.com> ---
Review of attachment 299278:

::: src/backends/meta-cursor-tracker.c
@@ +90,3 @@
+    {
+      g_object_ref (displayed_cursor);
+      tracker->displayed_cursor = displayed_cursor;

g_object_returns the ref'ed object as well - not sure if this change is because
you aren't aware of that or object to that stylistically.

::: src/backends/meta-cursor.c
@@ +54,3 @@
+} MetaCursorImage;
+
+struct _MetaCursorSpritePrivate

This is OK, but to express my opinion, I don't really see any reason to use a
private structure - private structures are basically useful for publicly
derivable objects where you need to have the object class in a public header.
MetaCursorSprite isn't derivable and it isn't even public.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150408/822ae792/attachment.html>