[Wayland-bugs] [Bug 744932] Wrong (ultra tiny/small) cursor size on HiDPI screen

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744932

--- Comment #99 from Jonas Ådahl <jadahl at gmail.com> ---
(In reply to Jonas Ådahl from comment #98)
> (In reply to Owen Taylor from comment #95)
> > Review of attachment 309854 [details] [review] [review]:
> > 
> > I attached this patch for review as part of this branch... but looking at
> > it, I'd definitely like it if we can figure out a way to separate it - it
> > looks entirely unrelated to the idea of the branch, and I'm not convinced by
> > it as a patch yet. Is there some way we can land this branch without this>

Indeed. I mentioned this in comment 86 (oh, many comments on this one now). In
the branch I did this, except I put the 4 patches I planned to push earlier
first (https://github.com/jadahl/mutter/commits/wip/hidpi-cursor is based on
https://github.com/jadahl/mutter/commits/wip/surface-roles )

> > 
> > ::: src/wayland/meta-xwayland.c
> > @@ +49,3 @@
> > +                                     META_WAYLAND_SURFACE_ROLE_XWAYLAND,
> > +                                     surface->resource,
> > +                                     WL_DISPLAY_ERROR_INVALID_OBJECT))
> > 
> > Hmmm ... I'm quite surprised that meta_wayland_surface_set_role() doesn't
> > follow Mutter standards for error handling, but returns 0/-1... I'd
> > definitely write this as:
> > 
> >  != 0
> > 
> > as other callers do to make it clearer what is going on.
> > 
> > (But please don't add more functions like this, and probably this one would
> > be better changed.)
> 
> Sure. I wanted to differentiate it from an actual server side error, but I
> can make it an int().

I misread what you wrote, and misremembered what I wrote. This one is clearly
just me forgetting to add the != 0 which I did in all the other set_role()
places.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150826/88e85efb/attachment.html>