[Wayland-bugs] [Bug 754158] New: wayland: Don't broadcast selection owner changes

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754158

            Bug ID: 754158
           Summary: wayland: Don't broadcast selection owner changes
    Classification: Platform
           Product: gtk+
           Version: unspecified
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: Backend: Wayland
          Assignee: gtk-bugs at gtk.org
          Reporter: jadahl at gmail.com
        QA Contact: gtk-bugs at gtk.org
                CC: rob at robster.org.uk, wayland-bugs at lists.freedesktop.org
     GNOME version: ---

I discovered this while debugging something looking like a memory leak in GNOME
Terminal. What seemed to be leaking was GDK_SELECTION_NOTIFY events created in
gdkselection-wayland.c but I have yet to find out why they actually leaked, or
if something other funky was going on. What I discovered though is that O(n^2)
"GDK_OWNER_CHANGE" events were emitted for n open terminal windows, which
seemed odd. This patch fixes that case by not broadcasting the change, but only
sending it once per time it happens.

I'm not sure whether this actually fixes the issues I have been seeing (I have
logs where ~59000 GDK_SELECTION_NOTIFY events are queued up but only ~27000
being emitted before more are being queued which is extremely odd by itself).
The extreme GDK_SELECTION_NOTIFY queueing I've been seeing is very hard to
reproduce, and happens once or less per day of quite heavy use. I have no idea
if this patch affects this since but I guess I will find out in due time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150827/023c30b0/attachment.html>