[Wayland-bugs] [Bug 91563] libinput keep open motion sensor input device

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91563

--- Comment #8 from Matthieu Gautier <dev at mgautier.fr> ---
(In reply to Bastien Nocera from comment #7)
> (In reply to Matthieu Gautier from comment #6)
> > Created attachment 118007 [details]
> > patch to add to linux tree, to add INPUT_PROP_ACCELEROMETER
> > 
> > Sorry for my silence but, as said Bastien, I was away.
> > (And, as I'm leaving again, I'll be silent for the next few weeks..)
> > 
> > 
> > Indeed, the tag INPUT_PROP_ACCELEROMETER is missing in applesmc. Adding it
> > [1] doesn't fix the problem. It shows that it is more complex that it seems
> > ...
> 
> The problem is that it's not an accelerometer, it only has 2 axis.

Yes, systemd 219 tag input as accelerometer if they have 3 axis.
Recent version add a test on INPUT_PROP_ACCELEROMETER property to also tag a
input device correctly.

> 
> > With the tag INPUT_PROP_ACCELEROMETER, a recent systemd version (>219, the
> > fedora22 version[2]) properly add the udev ID_INPUT_ACCELEROMETER=1 tag.
> > 
> > With this tag, libinput still open the device.
> 
> It shouldn't though.
> 
> > However, it seems to be the
> > right thing to do. Gnome(-shell?) now detect the device is a accelerometer
> > and display a button to deactivate screen rotation, so we should keep the
> > device open.
> 
> That would be iio-sensor-proxy opening it (once) and letting go of it until
> it receives a kevent saying it's changed coarse orientation (which we'll
> never receive because the driver doesn't send it).
> 
> I think that libinput should just ignore it. Is there a udev tag for that?

There is no test on ID_INPUT_ACCELEROMETER in libinput code to discard a input
device. We could add it if needed (as it is done for TABLET_PAD and JOYSTICK).
Another way, is to remove the ID_INPUT tag (What I've done with udev rule). 

Libinput should not open a device without ID_INPUT tag (but there is this bug
of gdm opening it at each "resume" without closing it).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150831/f96dfd56/attachment.html>