[Wayland-bugs] [Bug 93367] DWT not working on 13 inch Macbook Pro 2015 due to wrong dwt keyboard assignment

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93367

            Bug ID: 93367
           Summary: DWT not working on 13 inch Macbook Pro 2015 due to
                    wrong dwt keyboard assignment
           Product: Wayland
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: libinput
          Assignee: wayland-bugs at lists.freedesktop.org
          Reporter: tigersoldi at gmail.com

Created attachment 120491
  --> https://bugs.freedesktop.org/attachment.cgi?id=120491&action=edit
[PATCH] touchpad: for apple unibody touchpad, disable keyboards that  are not
the same product id for dwt

Hi, I have a 13 inch Macbook Pro 2015. DWT is completely broken on it.

The version I'm using is compiled from Master branch. The problem is that there
are two (or more?) keyboard devices: "Broadcom Corp. Bluetooth USB Host
Controller" and "Apple Inc. Apple Internal Keyboard / Trackpad". libinput
picked the wrong one for DWT detection.

Here is the hardware information:

[tiger at mbp ~]$ xinput
⎡ Virtual core pointer                        id=2    [master pointer  (3)]
⎜   ↳ Virtual core XTEST pointer                  id=4    [slave  pointer  (2)]
⎜   ↳ Broadcom Corp. Bluetooth USB Host Controller    id=11    [slave  pointer 
(2)]
⎜   ↳ bcm5974                                     id=13    [slave  pointer 
(2)]
⎣ Virtual core keyboard                       id=3    [master keyboard (2)]
    ↳ Virtual core XTEST keyboard                 id=5    [slave  keyboard (3)]
    ↳ Power Button                                id=6    [slave  keyboard (3)]
    ↳ Video Bus                                   id=7    [slave  keyboard (3)]
    ↳ Power Button                                id=8    [slave  keyboard (3)]
    ↳ Sleep Button                                id=9    [slave  keyboard (3)]
    ↳ Broadcom Corp. Bluetooth USB Host Controller    id=10    [slave  keyboard
(3)]
    ↳ Apple Inc. Apple Internal Keyboard / Trackpad    id=12    [slave 
keyboard (3)]
[tiger at mbp ~]$ xinput list-props 10
Device 'Broadcom Corp. Bluetooth USB Host Controller':
        <......>
    Device Product ID (261):    1452, 33424
        <......>
[tiger at mbp ~]$ xinput list-props 12
Device 'Apple Inc. Apple Internal Keyboard / Trackpad':
        <......>
    Device Product ID (261):    1452, 627
        <......>
[tiger at mbp ~]$ xinput list-props 13
Device 'bcm5974':
    Device Enabled (139):    1
        <......>
    libinput Disable While Typing Enabled (297):    1
    libinput Disable While Typing Enabled Default (298):    1
        <......>
    Device Product ID (261):    1452, 627
        <......>

I have a workaround by forcing the touchpad to use the keyboard with the same
vendor and product ID as the dwt keyboard. See the attached patch. Although it
works, I highly doubt it's the right solution. A better solution may be
supporting multiple dwt keyboards, or checking some other properties that can
filter out the fake keyboard device.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151214/c3bdc0d0/attachment.html>