[Wayland-bugs] [Bug 744933] Wrong input region on wayland in HiDPI

mutter (GNOME Bugzilla) bugzilla at gnome.org
Sat Feb 28 01:41:46 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=744933

drago01 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drago01 at gmail.com

--- Comment #4 from drago01 at gmail.com ---
We scale the input region by output_scale / buffer_scale ... so if you have
buffer_scale of 1 and output scale of 2 it gets scaled up by 2.

If the app sets buffer scale to 2 it gets scaled by 1 (i.e not at all) because
the app is supposed to be rendering at the correct resolution.

Also is it really "the upper half" or the the "upper left quarter" ?

We always scale the opaque region by the buffer scale which looks wrong ...
unfortunately can't test it right now does something like this work? :

diff --git a/src/wayland/meta-wayland-surface.c
b/src/wayland/meta-wayland-surface.c
index b1364e8..76c1fc1 100644
--- a/src/wayland/meta-wayland-surface.c
+++ b/src/wayland/meta-wayland-surface.c
@@ -426,7 +426,8 @@ commit_pending_state (MetaWaylandSurface      *surface,

   if (pending->opaque_region)
     {
-      pending->opaque_region = scale_region (pending->opaque_region,
surface->scale);
+      pending->opaque_region = scale_region (pending->opaque_region,
+                                            
meta_surface_actor_wayland_get_scale (META_SURFACE_ACTOR_WAYLAND
(surface->surface_actor)));
       meta_surface_actor_set_opaque_region (surface->surface_actor,
pending->opaque_region);
     }
   if (pending->input_region)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150228/ba992b10/attachment.html>


More information about the wayland-bugs mailing list