[Wayland-bugs] [Bug 91390] weston rdp-backend crash when "rdp4-key" option is used

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91390

            Bug ID: 91390
           Summary: weston rdp-backend crash when "rdp4-key" option is
                    used
           Product: Wayland
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: weston
          Assignee: wayland-bugs at lists.freedesktop.org
          Reporter: gajownik at gmail.com

Created attachment 117240
  --> https://bugs.freedesktop.org/attachment.cgi?id=117240&action=edit
weston output

Hi,

if you try to run weston with rdp-backend and rdp4-key option, program will
crash after client initializing a connection. For example execute 

weston --backend=rdp-backend.so --rdp4-key=test

and connect with any RDP client.

In src/compositor-rdp.c:1093 in rdp_peer_init() there's:

        client->Initialize(client);

        settings = client->settings;
        /* configure security settings */
        if (b->rdp_key)
                settings->RdpKeyFile = strdup(b->rdp_key);

client->Initialize(client) executes
libfreerdp/core/peer.c:freerdp_peer_initialize() from FreeRDP. It populates
settings->RdpServerRsaKey if settings->RdpKeyFile is set. As you can see above
rdp_peer_init() initializes settings->RdpKeyFile too late.

In the end settings->RdpServerRsaKey is not set and weston crashes when
libfreerdp/core/gcc.c:gcc_write_server_security_data() tries to access
    keyLen = settings->RdpServerRsaKey->ModulusLength;

Thanks,
     Dawid

weston and freerdp from today's git head.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20150719/c27352a1/attachment.html>