[Wayland-bugs] [Bug 756496] wayland: Make it possible to use a window type hint to map as a subsurface

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756496

Carlos Garnacho <carlosg at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313179|none                        |reviewed
             status|                            |

--- Comment #5 from Carlos Garnacho <carlosg at gnome.org> ---
Review of attachment 313179:

Nice refactor overall, the warnings will be handy for future cases, and it's
clearer about which window gets which wayland roles.

::: gdk/wayland/gdkwindow-wayland.c
@@ +1329,3 @@
+                     window);
+
+          create_fallback = TRUE;

It indeed makes sense to fall back to xdg_surface. I wonder if this function
overall wouldn't be clearer if we had a window_has_role() that returns false if
a GdkWindow has no xdg_surface, xdg_popup or wl_subsurface. That way we could
defer the fallback create_xdg_surface() call to a common place at the end of
the function, instead of being called from several places.

@@ +1903,3 @@
   gdk_wayland_window_sync_parent (window);

+  if (should_map_as_subsurface (window))

here you dropped the visibility/parent checks, aren't they necessary anymore?
it looks to me like we could trigger untimely wl_subsurface creation (eg. when
the window is not visible yet)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20151013/28a4d074/attachment.html>