[Wayland-bugs] [Bug 764413] Wayland: not fullscreenable gtk+ apps can be fullscreened

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764413

--- Comment #6 from Olivier Fourdan <ofourdan at redhat.com> ---
Created attachment 325360
  --> https://bugzilla.gnome.org/attachment.cgi?id=325360&action=edit
[PATCH] wayland: obey configure event if maximized/fullscreen

While discussing the possiblity to add an max size hint to xdg-shell on irc, I
have been pointed out to the current xdg-shell specification that states that
if the surface is maximized or fullscreen, the window geometry specified in the
configure event _must_ be obeyed by the client, which gtk+ doesn't (thus this
bug):

https://cgit.freedesktop.org/wayland/wayland-protocols/tree/unstable/xdg-shell/xdg-shell-unstable-v5.xml#n345

      <entry name="maximized" value="1" summary="the surface is maximized">
    <description summary="the surface is maximized">
      The surface is maximized. The window geometry specified in the configure
      event must be obeyed by the client.
    </description>
      </entry>
      <entry name="fullscreen" value="2" summary="the surface is fullscreen">
    <description summary="the surface is fullscreen">
      The surface is fullscreen. The window geometry specified in the configure
      event must be obeyed by the client.
    </description>
      </entry>

Therefore, this bug would be a bug in the application (ie gtk+) that doesn't
resize to the given size.

This patch makes it so that the given maximize/fullscreen size is obeyed,
gnome-calculator now maximize properly :-)

But I still reckon a max size hint would be beneficial to let the compositor
know that the window should not be resized to a greater size that specified, so
even if we fix this by becoming in-line with the xdg-shell specification, we
might want to also add the max size request to xdg-shell (if it ever reaches
consensus on the ML).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160404/faaa3249/attachment-0001.html>