[Wayland-bugs] [Bug 761312] memory leak
gtk+ (GNOME Bugzilla)
bugzilla at gnome.org
Wed Feb 3 18:30:28 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=761312
--- Comment #49 from Jasper St. Pierre <jstpierre at mecheye.net> ---
(In reply to Ray Strode [halfline] from comment #46)
> (In reply to Jonas Ã…dahl from comment #45)
> > I do however think that the two patches before this would be
> > better squashed into this one, since the intermediate state
> > isn't really an improvement (looks like we'll just always
> > draw on the live buffer, but maybe I'm wrong).
> Well, I split it out because the patch is kind of unwieldy.
>
> The cursor changes are really just a casualty of the other
> code, so i'd rather it didn't get thrown into the same patch.
>
> Cutting out the set_busy stuff up front doesn't make the
> code worse, we're already always drawing on a live buffer we
> aren't supposed to. That's because the temporary buffer it
> allocated in begin_paint and blitted out in end_paint, which
> are always bracketed together when used, so there's no chance
> a release will ever before the shared buffer is drawn to. So
> i'm just cutting out broken code, and having that rescission
> in the same patch as the fix makes the fix harder to follow.
The theory isn't that GTK+ will receive and process a receive, it's that it
will win the race and mutter will have completed the texture upload / copy by
then and queued up a release by then.
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20160203/ab346f3c/attachment.html>
More information about the wayland-bugs
mailing list