[Wayland-bugs] [Bug 761312] memory leak

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761312

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320458|none                        |reviewed
             status|                            |

--- Comment #56 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 320458:

Looks correct to me now. Marked as reviewed just because of a couple of minor
notes.

::: gdk/wayland/gdkwindow-wayland.c
@@ +208,3 @@
+   */
+  impl->committed_cairo_surface = NULL;
+

Stray newline.

@@ +366,3 @@
+  if (!impl->backfill_cairo_surface)
+    goto out;
+

Another possible early out would be possible if you calculated paint_region
earlier and finished early if it was empty.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160206/017c05c1/attachment.html>