[Wayland-bugs] [Bug 762561] Implement primary selection protocol

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762561

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jadahl at gmail.com

--- Comment #11 from Jonas Ådahl <jadahl at gmail.com> ---
(In reply to Carlos Garnacho from comment #7)
> (In reply to Jonas Ådahl from comment #4)
> > Review of attachment 322173 [details] [review] [review]:
> > 
> > Looks good except missing .gitignore entries.
> 
> gtk+ autogenerates those :).

Neat!

> 
> (In reply to Jonas Ådahl from comment #5)
> > Review of attachment 322174 [details] [review] [review]:
> > 
> > ::: gdk/wayland/gdkdevice-wayland.c
> > @@ +3031,3 @@
> >  
> > +  wayland_seat = GDK_WAYLAND_SEAT (seat);
> > +  g_hash_table_iter_init (&iter, wayland_seat->touches);
> > 
> > This is not related to this patch, but I fail to see when touches are added
> > to seat->touches. I do see when they are added to some GdkWaylandDeviceData
> > though. If seat->touches is always empty we'd regress here anyhow.
> 
> GdkWaylandDeviceData is currently a typedef to GdkWaylandSeat, there's a big
> rename fest awaiting to be done. I've been waiting for this, mainly in
> prevision for some of the branches had waiting to be merged (wayland-tablet
> is going to be fun...). I wanted to get to that during freeze times though.
> 
> In the time being, GdkWaylandDeviceData is GdkWaylandSeat.

Aahaaa. Thats not confusing at all :P

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160226/ae1d0a55/attachment.html>