[Wayland-bugs] [Bug 759161] wayland: dialog stacking without parents (RFC)

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759161

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317628|none                        |accepted-commit_now
             status|                            |

--- Comment #26 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 317628:

Looks good to me, otherwise

::: gdk/wayland/gdkwindow-wayland.c
@@ +190,3 @@
+{
+  if (!g_list_find (orphan_dialogs, window))
+    orphan_dialogs = g_list_append (orphan_dialogs, window);

If order doesn't matter, we normally prefer g_list_prepend to avoid an
unnecessary list traversal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20160107/6ab89e0c/attachment.html>