[Wayland-bugs] [Bug 761312] memory leak

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761312

--- Comment #9 from Ray Strode [halfline] <rstrode at redhat.com> ---
Review of attachment 320153:

::: gdk/wayland/gdkwindow-wayland.c
@@ +685,3 @@
+          cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
+          cairo_paint (cr);
+          cairo_destroy (cr);

So this is costly.  It won't happen much in practice now that mutter releases
the buffer before the frame callback, but we could optimize this by avoiding
the copy up front, only doing incremental changes into the staging buffer, and
then compositing the read back buffer on top of the incremental changes using
the DEST_OUT operator.

Another idea would be to use memcpy instead of cairo to do the copy.  We know
the buffers are linear with width == rowstride, so we can get by with one
memcpy call. It could be that cairo/pixman already fall back to a memcpy in
this situation though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20160131/22fe5fb4/attachment.html>