[Wayland-bugs] [Bug 767052] Wayland: Iconifying a modal dialog makes the app unusable

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767052

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328802|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Matthias Clasen <mclasen at redhat.com> ---
Review of attachment 328802:

::: gtk/gtkheaderbar.c
@@ +321,3 @@
+  has_toplevel_buttons = (!gtk_window_get_modal (window) &&
+                          gtk_window_get_transient_for (window) == NULL &&
+                          gtk_window_get_type_hint (window) ==
GDK_WINDOW_TYPE_HINT_NORMAL);

I could quibble with the variable name a bit - we _are_ adding the close button
regardless of this, which I think would count as a 'toplevel button'. Maybe
something like is_sovereign_window would be a bit more descriptive ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160601/8d949df2/attachment-0001.html>