[Wayland-bugs] [Bug 763298] wayland: connection flooded when dragging

gtk+ (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 9 17:16:53 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=763298

--- Comment #2 from Carlos Garnacho <carlosg at gnome.org> ---
Created attachment 323526
  --> https://bugzilla.gnome.org/attachment.cgi?id=323526&action=edit
gdkdnd: Add private gdk_drag_context_commit_drag_status() call

The way gdk_drag_status() may be called multiple times during the
processing of GDK_DRAG_MOTION events throughout the widget hierarchy
brings some superfluous messaging going in, esp. when it's the last
request the one we want to honor, yet we emit messaging requests on
all.

This is barely appreciable in the X11 backend, but due to the design
of the wayland protocol, quick series of changes like this it have
some self-amplificating consequences which may end up flooding the
connection.

Adding a gdk_drag_context_commit_drag_status() call, we ensure we
only do this once per GDK_DRAG_MOTION event, and only with the final
status, so we don't trigger spurious changes on the compositor
and the other peer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160309/c9929cff/attachment.html>


More information about the wayland-bugs mailing list