[Wayland-bugs] [Bug 763852] gdk/wayland: event source is not multi-thread aware

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763852

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324237|none                        |needs-work
             status|                            |

--- Comment #4 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 324237:

Sorry, missed another issue in the first version.

::: gdk/wayland/gdkeventsource.c
@@ +69,1 @@
   if (wl_display_flush (display->wl_display) < 0)

Out of scope for this patch, but maybe in scope for the bug, wl_display_flush()
may return EAGAIN if it didn't manage to flush everything, meaning we may
theoretically still dead-lock if we end up waiting for some reply to some
request idling in our queue.

@@ +81,2 @@
   if (source->display->event_pause_count > 0)
     return _gdk_event_queue_find_first (source->display) != NULL;

Oops. Need to call cancel() here as well, since we prepared but didn't read.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160318/e82db6f1/attachment.html>