[Wayland-bugs] [Bug 764385] Add tablet support

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764385

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mclasen at redhat.com

--- Comment #1 from Matthias Clasen <mclasen at redhat.com> ---
Some initial impressions from looking over the branch:

1) Do we forsee ever adding properties to GdkDeviceTool ? In that case, it
might be better to make it an object now, instead of a boxed type

2) gdk_device_update_tool just stores a pointer to the passed-in tool without
using gdk_device_ref/unref - is that safe ?

3) Maybe more concerning, _gdk_wayland_seat_remove_tool appears to be cxalling
g_object_unref on a GdkDeviceTool

4) The docs for ::tool-changed say it is emitted on proximity-in/out - what
happens if I simply switch between two different pens - I guess it is assumed
that there will always be proximity events around such a change ? Is that
guaranteed ?

5) Related to the previous point, I see a call to gdk_device_update_tool in
tablet_tool_handle_proximity_in, but not in tablet_tool_handle_proximity_out.
Oversight ?

6) Is there always going to be a 1:1 relationship between devices and tools ?
Could one imagine a fancy 'multi-pen' tablet that handles more than one tool
simultaneously ?

7) Grepping for GDK_SEAT_CAPABILITY_TABLET_STYLUS in gdk/*/*.c comes up empty -
I would have expected seats to expose that capabability (and associated master
devices) now ? Also, should that name be shortened to
GDK_SEAT_CAPABILITY_TABLET, maybe ? The stylus is just a tool, after all
(right?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160330/076495e8/attachment.html>