[Wayland-bugs] [Bug 770952] wayland: Don't destroy cursor backing storage when the buffer is released
gtk+ (GNOME Bugzilla)
bugzilla at gnome.org
Wed Sep 7 14:10:44 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=770952
Jonas Ådahl <jadahl at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #334911|none |reviewed
status| |
--- Comment #2 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 334911:
I don't think this is the correct solution. Before this patch you could set the
cursor and get rid of your cairo_surface_t reference without any unexpected
side effects, since the wl_surface implicitly had a reference to the cairo
surface via the buffer release callback. With this applied, would we destroy
the cairo surface would the wl_buffer also be destroyed (see
gdk_wayland_cairo_surface_destroy()).
You write that the issue is a refcount underrun, did you investigate how the
ref count went wrong?
For reference, each time one wl_surface.attach(buffer); wl_surface.commit(), we
should receive one wl_buffer.release on the attached buffer. Do we
cairo_surface_reference() for each time we attach and commit?
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160907/5af032e5/attachment.html>
More information about the wayland-bugs
mailing list