[Wayland-bugs] [Bug 781285] Key repeat cancel under Wayland should depend on which key is repeating

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781285

--- Comment #3 from Olivier Fourdan <ofourdan at redhat.com> ---
Created attachment 351038
  --> https://bugzilla.gnome.org/attachment.cgi?id=351038&action=edit
[PATCH v2] wayland: selectively cancel key repeat on key release

(In reply to Dan Torop from comment #2)
> Glad to hear back! 

Sorry, it's just that I didn't see your bug report initially.

> Mixed results: attachment 350636 [details] [review] does solve bug 781896,
> but it doesn't produce expected behavior in the second case of this bug. To
> rewrite that case as in your (clearer) steps in bug 781896:
> 
> Steps to reproduce:
> 
> 1. Press key "a" and keep the key pressed.
> 2. Press key "b" and release.
> 3. Press key "b" and keep the key pressed.
> 4. Release key "a".
> [...]

Yeah, I see what you mean. I don't have strong opinions there, whatever works
and is close enough to Xorg behavior will be fine with me, and Xorg behaves as
described here.

> As an aside, in your patch, you init repeat_key to 0. In my patch, I didn't
> initialize repeat_key, but do test it, assuming that, as it was only tested
> after a key release, it would by then have already been set by a keypress.
> Your approach is certainly safer!

Well it's easy enough to add.

> This bug report came from a problem with darktable to under Wayland
> (https://redmine.darktable.org/issues/11535#note-14), and both your
> attachment 350636 [details] [review] and my attachment 349836 [details]
> [review] solve that problem. I don't have the big picture of Wayland devices
> which you have, and would hate to blithely advocate removal of nkeys, but do
> want to put it out there for consideration!

Again I don't have strong opinions, we could go with your patch, it makes
sense.

I am attaching an updated version of your patch with some changes (it needed
updating after commit 83322a4 had landed), including the repeat_key value (I am
not sure this is actually needed, just the over cautious part of me asking for
that) - I also change the type of repeat_active to be a boolean, not hat it
makes much difference eventually, but in essence it is a boolean so klet's use
the appropriate type.

Lastly, I added a link to this bugzilla in your commit message, but if it was
me, I would shorten and simplify the commit message though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170504/ee726351/attachment.html>