[Wayland-bugs] [Bug 787407] New: wayland: gtk_shell1 capability enumeration badly numbered

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787407

            Bug ID: 787407
           Summary: wayland: gtk_shell1 capability enumeration badly
                    numbered
    Classification: Platform
           Product: gtk+
           Version: unspecified
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: Backend: Wayland
          Assignee: gtk-bugs at gtk.org
          Reporter: james at jamesh.id.au
        QA Contact: gtk-bugs at gtk.org
                CC: rob at robster.org.uk, wayland-bugs at lists.freedesktop.org
     GNOME version: ---

The gtk_shell1 Wayland protocol declares the following enumeration:

    <enum name="capability">
      <entry name="global_app_menu" value="1"/>
      <entry name="global_menu_bar" value="2"/>
      <entry name="desktop_icons" value="3"/>
    </enum>

These constants are then used to mask off bits in the value sent by the
"capabilities" event in order to convert them to GdkScreen settings.

This is fine for the first two, but it means the "gtk-shell-shows-desktop"
setting will only be set if global_app_menu and global_menu_bar are set. 
Presumably desktop_icons should be set to 4?

>From the look of the mutter source code, it only ever sends the global_app_menu
capability.  So I guess this particular code path never gets tested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20170907/15a251f8/attachment.html>