[Wayland-bugs] [Bug 101139] Acceleration still too slow with medium finger movements

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jan 9 05:34:14 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=101139

--- Comment #15 from Peter Hutterer <peter.hutterer at who-t.net> ---
fwiw, I went through the touchpad acceleration code again and could not find
anything obviously wrong. An important definition: a 'normalized' coordinate is
one that's converted from device units to units equivalent to a 1000dpi
standard mouse.

* starting point: tp_gesture_post_pointer_motion()
* tp_get_delta() returns a normalised delta
* this delta is passed to tp_filter_motion(), where it is converted back to
device units [the double-conversion is a leftover]. Only difference: the y axis
is pushed to the same resolution as the x axis so we can assume a delta in a
single coordinate system. That's the 'raw' variable.
* 'raw', in units/mm, is passed to filter_dispatch() which calls
accelerator_filter_post_normalized (see accelerator_interface_touchpad)
* 'raw' is passed further to accelerator_filter_generic() and
calculate_acceleration_factor().
* that calculates the velocity (in units/us) and passes it to
calculate_acceleration()
* that then calls the profile: touchpad_accel_profile_linear()
* the profile converts the speed (in units/us) to mm/s for easier understanding
and then applies the linear-ish accel function that calculates the accel
factor.
* that factor is passed back up and applied to the raw input delta
(accelerator_filter_post_normalized)
* the input delta is converted to 1000dpi normalized units and we finish
filter_dispatch() and send the accelerated delta to the caller

So aside from the slightly confusing conversions between systems, there is
nothing bleedingly obviously wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20180109/934a7ef2/attachment.html>


More information about the wayland-bugs mailing list