[Wayland-bugs] [Bug 780820] [Wayland] Focused window under application first window

[mutter (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780820

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #351962|none                        |reviewed
             status|                            |

--- Comment #21 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 351962:

The solution looks sane to me, but I have some comments on the implementation.

::: src/core/stack.c
@@ +113,3 @@
+                  window->desc);
+      return;
+    }

I don't think we should have a function called "meta_stack_add()" that might
not add anything. We should also try to avoid any per-winsys code anywhere
outside of the MetaWindow(X11|Wayland|Xwayland) files.

An idea:

- Add MetaWindowClass::is_stackable()

- MetaWindowWayland implements this as "has buffer", MetaWindowX11 as
!override_redirect

- Add a meta_stack_is_window_added() helper

- In both _new_shared() and meta_window_show() do "if
(!meta_stack_is_window_added (stack, window) && meta_window_is_stackable
(window) meta_stack_add (stack, window)" and in unmanage do if
(meta_stack_is_window_added (stack, window)) meta_stack_remove (stack, window);
(alternatively add a meta_stack_maybe_add() that hides parts of the logic)

- We could remove the meta_bug() thing below, which would be dead code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20180109/9781208a/attachment.html>