[Wayland-bugs] [Bug 107314] Crash on resuming laptop with screen connected

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107314

Olivier Fourdan <fourdan at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fourdan at xfce.org

--- Comment #7 from Olivier Fourdan <fourdan at xfce.org> ---
Created attachment 141463
  --> https://bugs.freedesktop.org/attachment.cgi?id=141463&action=edit
[RFC PATCH xserver] xwayland: ignore sync callback if window is destroyed

(In reply to Daniel Stone from comment #6)
> Seems safe enough. When we free the vblanks (which, when we're aborting
> here, can only happen because the window has been destroyed), [...]

Roman pointed out on the ML a crash possibly caused by that patch.

What about this patch then?

On destroy, `xwl_present_cleanup()` would free the `xwl_present_window` but
leave its reference in the window's privates, so that other functions could
still find it and use freed memory.

That patch there https://patchwork.freedesktop.org/patch/247271/ fixes that, so
with this if we just check for `xwl_present_window` being nun-null in
`xwl_present_sync_callback()` we should avoid the crash, cleanly, no?

If the idea makes sense (and if someone cwould be willing to try it) and if it
works, I would send that to the ML for further review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20180905/a31f63c3/attachment.html>