<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Black content when using testfilechooser auto completer"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762120">bug 762120</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #321340 status</td>
<td>none
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Black content when using testfilechooser auto completer"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762120#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Black content when using testfilechooser auto completer"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762120">bug 762120</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=321340&action=diff" name="attach_321340" title="wayland: Handle after-paint invocations when nothing was painted">attachment 321340</a> <a href="attachment.cgi?id=321340&action=edit" title="wayland: Handle after-paint invocations when nothing was painted">[details]</a></span> <a href='review?bug=762120&attachment=321340'>[review]</a>:
so this looks fine to me, but it does nicely illustrate an interesting point: a
commit operation could be one or more different things. I wonder if a cleaner
approach than adding another boolean, would be to change the pending_commit
variable to take a bitfield of commit flags instead? Then you could set
pending_commit |= PENDING_DAMAGE; pending_commit |= PENDING_BUFFER_ATTACHMENT;
pending_commit |= SUBSURFACE_SET_POSITION etc etc.
and inside on_frame_clock_after_paint you could do
if (pending_commit & PENDING_DAMAGE)
read_back_cairo_surface (...)
...
if (pending_commit & PENDING_BUFFER_ATTACHMENT)
impl->committed_cairo_surface = ...
just an idea, what you've got seems fine.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>