<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement primary selection protocol"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762561">bug 762561</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #322175 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement primary selection protocol"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762561#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement primary selection protocol"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762561">bug 762561</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=322175&action=diff" name="attach_322175" title="wayland: Implement the (so far internal) primary selection protocol">attachment 322175</a> <a href="attachment.cgi?id=322175&action=edit" title="wayland: Implement the (so far internal) primary selection protocol">[details]</a></span> <a href='review?bug=762561&attachment=322175'>[review]</a>:
::: gdk/wayland/gdkdevice-wayland.c
@@ +931,3 @@
+primary_selection_data_offer (void *data,
+ struct gtk_primary_selection_device
*wp_primary_selection_device,
+ struct gtk_primary_selection_offer
*wp_primary_offer)
wp? :P
::: gdk/wayland/gdkselection-wayland.c
@@ +272,3 @@
{
selection_buffer_ref (buffer);
+ g_input_stream_read_bytes_async (buffer->stream, READ_BUFFER_SIZE,
G_PRIORITY_DEFAULT,
The changes to this function and selection_buffer_read_cb doesn't look related
to the patch.
@@ +285,2 @@
info = g_slice_new0 (DataOfferData);
info->offer = offer;
Should info->offer now be called "offer_data" or something now instead maybe?
@@ +432,3 @@
+static void
+primary_offer_offer (void *data,
+ struct gtk_primary_selection_offer *wp_offer,
wp_ here again and in a few other places.
@@ +879,3 @@
+ {
+ window = wayland_selection->primary_owner;
+ selection = atoms[ATOM_PRIMARY];
Why do you check if the source is a primary selection source here? I wouldn't
expect that wl_data_source.send would ever be called for the primary selection.
@@ +914,3 @@
atom = atoms[ATOM_DND];
+ else if (source == (gpointer) wayland_selection->primary_source)
+ atom = atoms[ATOM_PRIMARY];
Same here. This is a wl_data_source related function. Why would you check if
its a primary selection source?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>