<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Setting a popover 'relative_to' a widget on an offscreen window crashes gtk+"
href="https://bugzilla.gnome.org/show_bug.cgi?id=761156#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Setting a popover 'relative_to' a widget on an offscreen window crashes gtk+"
href="https://bugzilla.gnome.org/show_bug.cgi?id=761156">bug 761156</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=761156#c7">comment #7</a>)
<span class="quote">> Review of <span class=""><a href="attachment.cgi?id=322536&action=diff" name="attach_322536" title="GtkWindow: Don't realize popover if added to offscreen window">attachment 322536</a> <a href="attachment.cgi?id=322536&action=edit" title="GtkWindow: Don't realize popover if added to offscreen window">[details]</a></span> <a href='review?bug=761156&attachment=322536'>[review]</a> [review]:
>
> This feels wrong to me to check for an offscreen window in this one place.
> Can we not instead fix up the transient loop check to not croak ?</span >
If we don't check it there, or skip setting the transiency in the realize
function, we pass, according to the API, invalid input to
gdk_window_set_transient_for(). gdk_window_set_transient_for() takes two
toplevel GdkWindow's, so passing an offscreen GdkWindow as a parent is not
valid.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>