<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] GDK doesn't remember unmaximized or unfullscreen size"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762713#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] GDK doesn't remember unmaximized or unfullscreen size"
href="https://bugzilla.gnome.org/show_bug.cgi?id=762713">bug 762713</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span></b>
<pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=762713#c10">comment #10</a>)
<span class="quote">> Review of <span class=""><a href="attachment.cgi?id=322632&action=diff" name="attach_322632" title="[PATCH v4] wayland: restore size when configure size is 0x0">attachment 322632</a> <a href="attachment.cgi?id=322632&action=edit" title="[PATCH v4] wayland: restore size when configure size is 0x0">[details]</a></span> <a href='review?bug=762713&attachment=322632'>[review]</a> [review]:
>
> ::: gdk/wayland/gdkwindow-wayland.c
> @@ +2335,2 @@
> if (impl->display_server.xdg_surface)
> xdg_surface_set_maximized (impl->display_server.xdg_surface);
>
> Do we really need to save in maximize and fullscreen ? Shouldn't it be
> enough to save whenever we configure the surface with a new size ?</span >
That was my first approach as well but that won't work because gtk+
reconfigures the window to a much larger size prior to changing its state (see
<a href="show_bug.cgi?id=762713#c3">comment 3</a>), so by saving the size in the configure function, we'd save the
wrong size.
<span class="quote">> But you probably do need an extra save() call in sync_margin(), since the
> saved size depends on the margins ?</span >
We save the size only when not fullscreen nor maximized, and we reuse them when
leaving that state (and only when the given size is 0x0), so even if the
margins do change while fullscreen or maximized, or even when in normal state
we don't really care, we're not using/applying them.
But more importantly, saving the size in sync_margin() does break the case
Jonas brought up in <a href="show_bug.cgi?id=762713#c7">comment 7</a>, ie a resize while hidden so I think it's better
as it is now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>