<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Make window creation hooks in tab DnD work on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763387">bug 763387</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #323534 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Make window creation hooks in tab DnD work on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763387#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Make window creation hooks in tab DnD work on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763387">bug 763387</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=323534&action=diff" name="attach_323534" title="GtkNotebook: Make tab DnD use application/x-rootwindow-drop again">attachment 323534</a> <a href="attachment.cgi?id=323534&action=edit" title="GtkNotebook: Make tab DnD use application/x-rootwindow-drop again">[details]</a></span> <a href='review?bug=763387&attachment=323534'>[review]</a>:
::: gtk/gtknotebook.c
@@ +1289,3 @@
priv->switch_tab_timer = 0;
+ priv->source_targets = gtk_target_list_new (src_notebook_targets,
+ G_N_ELEMENTS
(src_notebook_targets));
I wonder: Can we actually set this unconditionally as target ? Will this make
it so that we always allow tabs to be dragged away, even if they aren't
detachable ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>