<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - gdk/wayland: event source is not multi-thread aware" href="https://bugzilla.gnome.org/show_bug.cgi?id=763852#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - gdk/wayland: event source is not multi-thread aware" href="https://bugzilla.gnome.org/show_bug.cgi?id=763852">bug 763852</a> from <a href="page.cgi?id=describeuser.html&login=ystreet00%40gmail.com" title="Matthew Waters (ystreet00) <ystreet00@gmail.com>"> Matthew Waters (ystreet00)</a> <pre>Created <a href="attachment.cgi?id=324237&action=diff" name="attach_324237" title="gdk/wayland: use the multi-thread safe wayland dispatching API">attachment 324237</a> <a href="attachment.cgi?id=324237&action=edit" title="gdk/wayland: use the multi-thread safe wayland dispatching API">[details]</a> <a href='review?bug=763852&attachment=324237'>[review]</a> gdk/wayland: use the multi-thread safe wayland dispatching API (In reply to Jonas Ådahl from <a href="show_bug.cgi?id=763852#c2">comment #2</a>) > Indeed. The patch looks mostly good, except the inline comment and that you > don't cancel on finalize, if we ended up having prepared and not dispatched. The reentrant thing? I've changed it to mention balancing prepare/cancel/read instead which makes more sense. cancel on finalize() is fixed. > FWIW, the wl_display_dispatch(_queue)() API is multi-thread safe if used > correctly (i.e. don't mix poll() and dispatch() more or less), so should > probably update the commit message to reflect that. Something like this? > ::: gdk/wayland/gdkeventsource.c > @@ +63,3 @@ > + g_error ("Error dispatching display: %s", g_strerror (errno)); > + } > + > > You should set source->reading to TRUE here. Fixed</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>