<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ystreet00%40gmail.com" title="Matthew Waters (ystreet00) <ystreet00@gmail.com>"> <span class="fn">Matthew Waters (ystreet00)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk/wayland: event source is not multi-thread aware"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763852">bug 763852</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #324237 status</td>
<td>needs-work
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #324237 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk/wayland: event source is not multi-thread aware"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763852#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk/wayland: event source is not multi-thread aware"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763852">bug 763852</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ystreet00%40gmail.com" title="Matthew Waters (ystreet00) <ystreet00@gmail.com>"> <span class="fn">Matthew Waters (ystreet00)</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=324239&action=diff" name="attach_324239" title="gdk/wayland: use the multi-thread safe wayland dispatching API">attachment 324239</a> <a href="attachment.cgi?id=324239&action=edit" title="gdk/wayland: use the multi-thread safe wayland dispatching API">[details]</a></span> <a href='review?bug=763852&attachment=324239'>[review]</a>
gdk/wayland: use the multi-thread safe wayland dispatching API
(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=763852#c4">comment #4</a>)
<span class="quote">> Review of <span class="bz_obsolete"><a href="attachment.cgi?id=324237&action=diff" name="attach_324237" title="gdk/wayland: use the multi-thread safe wayland dispatching API">attachment 324237</a> <a href="attachment.cgi?id=324237&action=edit" title="gdk/wayland: use the multi-thread safe wayland dispatching API">[details]</a></span> <a href='review?bug=763852&attachment=324237'>[review]</a> [review]:
>
> Sorry, missed another issue in the first version.
>
> ::: gdk/wayland/gdkeventsource.c
> @@ +69,1 @@
> if (wl_display_flush (display->wl_display) < 0)
>
> Out of scope for this patch, but maybe in scope for the bug,
> wl_display_flush() may return EAGAIN if it didn't manage to flush
> everything, meaning we may theoretically still dead-lock if we end up
> waiting for some reply to some request idling in our queue.</span >
Fixing that would require polling with G_IO_OUT as well to check writability.\
and then state tracking for that.
<span class="quote">> @@ +81,2 @@
> if (source->display->event_pause_count > 0)
> return _gdk_event_queue_find_first (source->display) != NULL;
>
> Oops. Need to call cancel() here as well, since we prepared but didn't read.</span >
Fixed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>