<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - gdkdevice-wayland.c cleanups" href="https://bugzilla.gnome.org/show_bug.cgi?id=763859#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - gdkdevice-wayland.c cleanups" href="https://bugzilla.gnome.org/show_bug.cgi?id=763859">bug 763859</a> from <a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> Carlos Garnacho</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=763859#c4">comment #4</a>) > Review of <a href="attachment.cgi?id=324247&action=diff" name="attach_324247" title="wayland: Remove GdkWaylandDeviceData pointer in GdkWaylandDevice">attachment 324247</a> <a href="attachment.cgi?id=324247&action=edit" title="wayland: Remove GdkWaylandDeviceData pointer in GdkWaylandDevice">[details]</a> <a href='review?bug=763859&attachment=324247'>[review]</a> [review]: > > Looks good to me. Do you want this on 3.20.x too, in addition to master ? > Might make cherry picking easier Yeah, I was thinking the same, might not help as much in the end if we go full blown into separating gdkseat-wayland.c after tablet support... but still better to have code match anyway. (In reply to Matthias Clasen from <a href="show_bug.cgi?id=763859#c5">comment #5</a>) > Review of <a href="attachment.cgi?id=324248&action=diff" name="attach_324248" title="wayland: Remove GdkWaylandDeviceData typedef">attachment 324248</a> <a href="attachment.cgi?id=324248&action=edit" title="wayland: Remove GdkWaylandDeviceData typedef">[details]</a> <a href='review?bug=763859&attachment=324248'>[review]</a> [review]: > > Does the gdkdevice-wayland.c belong into the previous patch ? Or maybe a > separate one. In any case, it might be nice to have "Remove unused typedef" > be a separate patch that does just that. Right, will at least separate the typedef.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>