<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland: not fullscreenable gtk+ apps can be fullscreened" href="https://bugzilla.gnome.org/show_bug.cgi?id=764413#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland: not fullscreenable gtk+ apps can be fullscreened" href="https://bugzilla.gnome.org/show_bug.cgi?id=764413">bug 764413</a> from <a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> Olivier Fourdan</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=764413#c3">comment #3</a>) > At the end of that bug, you said: forget about that patch, it's not needed. > > Now it is needed after all ? It was not needed for the original issue in <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - GtkWindow reacts on maximize action even if it is fixed-width" href="show_bug.cgi?id=757530">bug 757530</a> in its initial description. There are two slightly different issues, one is the app requesting to fullscreen/maximize state by itself, although its own constraints wouldn't allow for it, that was <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - GtkWindow reacts on maximize action even if it is fixed-width" href="show_bug.cgi?id=757530">bug 757530</a> which was addressed with <a href="attachment.cgi?id=314815&action=diff" name="attach_314815" title="[PATCH 3/3] window: maximize on double click only if allowed">attachment 314815</a> <a href="attachment.cgi?id=314815&action=edit" title="[PATCH 3/3] window: maximize on double click only if allowed">[details]</a> <a href='review?bug=764413&attachment=314815'>[review]</a> (ie teach gtk+ not to try to switch its state to maximized if the window cannot). There is another issue that I found out while working on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - GtkWindow reacts on maximize action even if it is fixed-width" href="show_bug.cgi?id=757530">bug 757530</a> which is with the Wayland compositor trying to switch a window to fullscreen/maximized while the window itself should not be allowed (again, due to its constraints), this would be this <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland: not fullscreenable gtk+ apps can be fullscreened" href="show_bug.cgi?id=764413">bug 764413</a> here instead, and <a href="attachment.cgi?id=314814&action=diff" name="attach_314814" title="[Patch 2/3] wayland: apply maximized state only when possible">attachment 314814</a> <a href="attachment.cgi?id=314814&action=edit" title="[Patch 2/3] wayland: apply maximized state only when possible">[details]</a> <a href='review?bug=764413&attachment=314814'>[review]</a> was to address this (other) particular issue - As <a href="attachment.cgi?id=314814&action=diff" name="attach_314814" title="[Patch 2/3] wayland: apply maximized state only when possible">attachment 314814</a> <a href="attachment.cgi?id=314814&action=edit" title="[Patch 2/3] wayland: apply maximized state only when possible">[details]</a> <a href='review?bug=764413&attachment=314814'>[review]</a> did not really reached a consensus, I preferred to move forward as this wasn't required for <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - GtkWindow reacts on maximize action even if it is fixed-width" href="show_bug.cgi?id=757530">bug 757530</a>. The problem with Wayland is that we don't have a way for the client to tell what should be the maximum size if a given window, so the compositor might always try to maximize/fullscreen a window, and its then up to the client to deny the change. Either we take the approach followed in <a href="attachment.cgi?id=314814&action=diff" name="attach_314814" title="[Patch 2/3] wayland: apply maximized state only when possible">attachment 314814</a> <a href="attachment.cgi?id=314814&action=edit" title="[Patch 2/3] wayland: apply maximized state only when possible">[details]</a> <a href='review?bug=764413&attachment=314814'>[review]</a> or we (try to) add some hints[*] in xdg-shell that would allow an application to tell the compositor that some window states such as maximized/fullscreen should not be possible. [*] by the lack of a better word here, some people do not like the word "hint" for this and would avoid it, but I use it here as this is what X uses so we have a broader common understanding...</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>