<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Two finger tap on title bars non-functional on GTK3 apps and wayland" href="https://bugzilla.gnome.org/show_bug.cgi?id=764519#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Two finger tap on title bars non-functional on GTK3 apps and wayland" href="https://bugzilla.gnome.org/show_bug.cgi?id=764519">bug 764519</a> from <a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> Carlos Garnacho</a> <pre>Created <a href="attachment.cgi?id=325359&action=diff" name="attach_325359" title="wayland: remove pressed button checks from meta_wayland_pointer_can_grab_surface()">attachment 325359</a> <a href="attachment.cgi?id=325359&action=edit" title="wayland: remove pressed button checks from meta_wayland_pointer_can_grab_surface()">[details]</a> <a href='review?bug=764519&attachment=325359'>[review]</a> wayland: remove pressed button checks from meta_wayland_pointer_can_grab_surface() Leave these checks up to the callers, the only uses of this function (indirect, through meta_wayland_seat_get_grab_info) are [wl_shell|xdg]_surface.move/resize/show_window_menu. In move/resize it makes sense to check for a button being pressed, because we must expect a button release event. However for xdg_surface.show_window_menu we 1) don't strictly need further events and 2) we must account for press+release event pairs being processed at once in the compositor before the client sees the former. That is eg. the case of touchpad 2nd/3rd button tap emulation, multifinger taps will emit the event pair at once, so when the client manages to request xdg_surface.show_window_menu, it'll be too late in the compositor side, so the request is ignored.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>