<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Busy loop while "Displays" page is active"
href="https://bugzilla.gnome.org/show_bug.cgi?id=764374">bug 764374</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #325339 status</td>
<td>reviewed
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #325339 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Busy loop while "Displays" page is active"
href="https://bugzilla.gnome.org/show_bug.cgi?id=764374#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Busy loop while "Displays" page is active"
href="https://bugzilla.gnome.org/show_bug.cgi?id=764374">bug 764374</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=325357&action=diff" name="attach_325357" title="[PATCH v4] wayland: Do not resize with the same size">attachment 325357</a> <a href="attachment.cgi?id=325357&action=edit" title="[PATCH v4] wayland: Do not resize with the same size">[details]</a></span> <a href='review?bug=764374&attachment=325357'>[review]</a>
[PATCH v4] wayland: Do not resize with the same size
(In reply to Matthias Clasen from <a href="show_bug.cgi?id=764374#c12">comment #12</a>)
<span class="quote">> Review of <span class="bz_obsolete"><a href="attachment.cgi?id=325339&action=diff" name="attach_325339" title="[PATCH] wayland: Do not resize with the same size">attachment 325339</a> <a href="attachment.cgi?id=325339&action=edit" title="[PATCH] wayland: Do not resize with the same size">[details]</a></span> <a href='review?bug=764374&attachment=325339'>[review]</a> [review]:
>
> I must say that I find the "from_configure" parameter naming mildly
> confusing in a function called gdk_wayland_window_configure, and looking at
> the callers, the extra TRUE/FALSE doesn't really communicate what is going
> on. An alternative approach might be to have a separate function, say
> gdk_wayland_window_maybe_configure() which would do the shortcut, and then
> call gdk_wayland_window_configure().</span >
Sure, makes sense, updated patch attached.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>