<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Two finger tap on title bars non-functional on GTK3 apps and wayland" href="https://bugzilla.gnome.org/show_bug.cgi?id=764519#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Two finger tap on title bars non-functional on GTK3 apps and wayland" href="https://bugzilla.gnome.org/show_bug.cgi?id=764519">bug 764519</a> from <a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> Carlos Garnacho</a> <pre>Oops, lost track of this bug... (In reply to Rui Matos from <a href="show_bug.cgi?id=764519#c5">comment #5</a>) > Review of <a href="attachment.cgi?id=325359&action=diff" name="attach_325359" title="wayland: remove pressed button checks from meta_wayland_pointer_can_grab_surface()">attachment 325359</a> <a href="attachment.cgi?id=325359&action=edit" title="wayland: remove pressed button checks from meta_wayland_pointer_can_grab_surface()">[details]</a> <a href='review?bug=764519&attachment=325359'>[review]</a> [review]: > > otherwise looks good > > ::: src/wayland/meta-wayland-surface.c > @@ +1363,3 @@ > MetaWaylandSurface *surface = wl_resource_get_user_data (resource); > > + if (!meta_wayland_seat_get_grab_info (seat, surface, serial, NULL, NULL, > FALSE)) > > the boolean argument should be the 4th and likewise on the other calls below Indeed, that's what I get for a last minute quick refactor. Pushing a fixed patch. Thanks for the review!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>