<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] very slow scrolling in GtkMenu using the touchpad"
href="https://bugzilla.gnome.org/show_bug.cgi?id=765939">bug 765939</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #327235 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] very slow scrolling in GtkMenu using the touchpad"
href="https://bugzilla.gnome.org/show_bug.cgi?id=765939#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] very slow scrolling in GtkMenu using the touchpad"
href="https://bugzilla.gnome.org/show_bug.cgi?id=765939">bug 765939</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=327235&action=diff" name="attach_327235" title="[PATCH 2/2] gtkmenu: ignore emulated scroll events">attachment 327235</a> <a href="attachment.cgi?id=327235&action=edit" title="[PATCH 2/2] gtkmenu: ignore emulated scroll events">[details]</a></span> <a href='review?bug=765939&attachment=327235'>[review]</a>
[PATCH 2/2] gtkmenu: ignore emulated scroll events
I think you could do with the if (!_gdk_event_get_pointer_emulated(...)) check
on the top of the function, we also want to avoid the case of x11 drivers
sending both 4-7 button and smooth scroll events with mouse wheels (in that
case the latter has the "emulated" flag)
Multiplying the smooth scroll value by MENU_SCROLL_STEP2 sounds alright, I'm
not sure I like much obeying delta_x though :). IMO it's better to obey only
the axis that matches visually when we know the device can do both, otherwise
scrolling along the right diagonal would/could make scrolling jump between
upwards and downwards.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>