<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ystreet00%40gmail.com" title="Matthew Waters (ystreet00) <ystreet00@gmail.com>"> <span class="fn">Matthew Waters (ystreet00)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk/wayland: event source is not multi-thread aware"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763852">bug 763852</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #325118 status</td>
<td>needs-work
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #325118 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk/wayland: event source is not multi-thread aware"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763852#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk/wayland: event source is not multi-thread aware"
href="https://bugzilla.gnome.org/show_bug.cgi?id=763852">bug 763852</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ystreet00%40gmail.com" title="Matthew Waters (ystreet00) <ystreet00@gmail.com>"> <span class="fn">Matthew Waters (ystreet00)</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=327362&action=diff" name="attach_327362" title="gdk/wayland: use the multi-thread safe wayland dispatching API">attachment 327362</a> <a href="attachment.cgi?id=327362&action=edit" title="gdk/wayland: use the multi-thread safe wayland dispatching API">[details]</a></span> <a href='review?bug=763852&attachment=327362'>[review]</a>
gdk/wayland: use the multi-thread safe wayland dispatching API
(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=763852#c11">comment #11</a>)
<span class="quote">> Review of <span class="bz_obsolete"><a href="attachment.cgi?id=325118&action=diff" name="attach_325118" title="gdk/wayland: use the multi-thread safe wayland dispatching API">attachment 325118</a> <a href="attachment.cgi?id=325118&action=edit" title="gdk/wayland: use the multi-thread safe wayland dispatching API">[details]</a></span> <a href='review?bug=763852&attachment=325118'>[review]</a> [review]:
>
> I think it looks fine except for one detail which I haven't managed to find
> clear documentation about.
>
> ::: gdk/wayland/gdkeventsource.c
> @@ +56,3 @@
> + * wl_display_read_events() or wl_display_cancel_read()
> + * (in gdk_event_source_check() */
> + g_assert (source->reading == FALSE);
>
> I can't find any documentation saying a non-mainloop caller may never
> prepare() only once before calling check(), so I think this assert is a bit
> dangerous. In other words, I think we should maybe change this assert to if
> (source->reading) return FALSE;</span >
Now uses if (source->reading) return FALSE;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>