<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not rely on memfd as it requires a fairly recent kernel"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766341">bug 766341</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #327791 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not rely on memfd as it requires a fairly recent kernel"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766341#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not rely on memfd as it requires a fairly recent kernel"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766341">bug 766341</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=327791&action=diff" name="attach_327791" title="wayland: fall back to shm_open if memfd unavailable">attachment 327791</a> <a href="attachment.cgi?id=327791&action=edit" title="wayland: fall back to shm_open if memfd unavailable">[details]</a></span> <a href='review?bug=766341&attachment=327791'>[review]</a>:
Other than that, looks fine.
::: gdk/wayland/gdkdisplay-wayland.c
@@ +1100,3 @@
+ random_byte == '/')
+ continue;
+
This looks a bit manual and wasteful to me. Instead of throwing away most of
the randomness and using only one byte at a time, I'd probably translate the
whole random int into hex digits in one go. No need to look out for / and \0
either then.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>