<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not rely on memfd as it requires a fairly recent kernel"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766341">bug 766341</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #327992 status</td>
<td>accepted-commit_now
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not rely on memfd as it requires a fairly recent kernel"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766341#c27">Comment # 27</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Do not rely on memfd as it requires a fairly recent kernel"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766341">bug 766341</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=327992&action=diff" name="attach_327992" title="wayland: fix error handling for memfd_create">attachment 327992</a> <a href="attachment.cgi?id=327992&action=edit" title="wayland: fix error handling for memfd_create">[details]</a></span> <a href='review?bug=766341&attachment=327992'>[review]</a>:
::: gdk/wayland/gdkdisplay-wayland.c
@@ +1092,3 @@
+ {
+ g_critical (G_STRLOC ": creating shared memory file failed: %m");
+ return NULL;
still needs work, this shouldn't say NULL, but should say -1.
@@ -1090,3 @@
- ret = syscall (__NR_memfd_create, "gdk-wayland", MFD_CLOEXEC);
-
- if (ret < 0)
we ended up inadvertently losing error handling here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>