<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Do not rely on memfd as it requires a fairly recent kernel" href="https://bugzilla.gnome.org/show_bug.cgi?id=766341#c17">Comment # 17</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Do not rely on memfd as it requires a fairly recent kernel" href="https://bugzilla.gnome.org/show_bug.cgi?id=766341">bug 766341</a> from <a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> Ray Strode [halfline]</a> <pre>Review of <a href="attachment.cgi?id=327976&action=diff" name="attach_327976" title="wayland: fall back to shm_open if memfd unavailable">attachment 327976</a> <a href="attachment.cgi?id=327976&action=edit" title="wayland: fall back to shm_open if memfd unavailable">[details]</a> <a href='review?bug=766341&attachment=327976'>[review]</a>: ::: gdk/wayland/gdkdisplay-wayland.c @@ +1132,1 @@ ret = syscall (__NR_memfd_create, "gdk-wayland", MFD_CLOEXEC); so i'm not handling EINTR here, which means we could end up using yucky shm fds on memfd systems sporatically. I'm also not remembering to use fall back for subsequent calls so users stuck with yucky shm fds will do futile memfd_create calls every time.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>