<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ebassi%40gmail.com" title="Emmanuele Bassi (:ebassi) <ebassi@gmail.com>"> <span class="fn">Emmanuele Bassi (:ebassi)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland: gdk_screen_get_monitor_at_window() unreliable under Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766566">bug 766566</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #328081 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland: gdk_screen_get_monitor_at_window() unreliable under Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766566#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland: gdk_screen_get_monitor_at_window() unreliable under Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=766566">bug 766566</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ebassi%40gmail.com" title="Emmanuele Bassi (:ebassi) <ebassi@gmail.com>"> <span class="fn">Emmanuele Bassi (:ebassi)</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=328081&action=diff" name="attach_328081" title="[PATCH 3/3] wayland: Add get_monitor_at_window to Wayland backend">attachment 328081</a> <a href="attachment.cgi?id=328081&action=edit" title="[PATCH 3/3] wayland: Add get_monitor_at_window to Wayland backend">[details]</a></span> <a href='review?bug=766566&attachment=328081'>[review]</a>:
::: gdk/wayland/gdkdisplay-wayland.c
@@ +853,3 @@
+
+ output = gdk_wayland_window_get_wl_output (window);
+ struct wl_output *output;
Instead of nesting the for loop under the if, you can flip the condition check
and bail out early:
if (output == NULL)
return NULL;
for (i = 0; ...
{
...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>