<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland: gtkcombox menu misplaced in master" href="https://bugzilla.gnome.org/show_bug.cgi?id=766722#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wayland: gtkcombox menu misplaced in master" href="https://bugzilla.gnome.org/show_bug.cgi?id=766722">bug 766722</a> from <a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> Olivier Fourdan</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=766722#c2">comment #2</a>) > Review of <a href="attachment.cgi?id=328265&action=diff" name="attach_328265" title="[PATCH RFC] wayland: use get_monitor_at_point() consistently">attachment 328265</a> <a href="attachment.cgi?id=328265&action=edit" title="[PATCH RFC] wayland: use get_monitor_at_point() consistently">[details]</a> <a href='review?bug=766722&attachment=328265'>[review]</a> [review]: > > I'm not convinced that this is really right - the semantics of > monitor_at_window and monitor_at_point are not inconsistent, and at_point > has even less of a chance to work without global coordinates The patch is right in the sense that it makes the result consistently wrong just as before <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - Wayland: gdk_screen_get_monitor_at_window() unreliable under Wayland" href="show_bug.cgi?id=766566">bug 766566</a>. And I completely agree, this patch was mostly an RFC and a placeholder for people who would complain about menu placement under multi-screen in Wayland using gtk+ from master. The best solution is to wait for the fixes for <a class="bz_bug_link bz_status_NEW " title="NEW - GTK should let GDK position menus" href="show_bug.cgi?id=756579">bug 756579</a> to land.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>