<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Long window titles crash clients"
href="https://bugzilla.gnome.org/show_bug.cgi?id=767241">bug 767241</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>carlosg@gnome.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Long window titles crash clients"
href="https://bugzilla.gnome.org/show_bug.cgi?id=767241#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Long window titles crash clients"
href="https://bugzilla.gnome.org/show_bug.cgi?id=767241">bug 767241</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span></b>
<pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=767241#c3">comment #3</a>)
<span class="quote">> But the buffers we use are created by wl_shm_pool_create_buffer. We use it
> for the entire window contents w*scale * h*scale * 4 bytes - that can easily
> go beyond 4096. I must say wl_buffer is very confusing in the wayland
> codebase. There's some headers where it is deprecated, e.g.
>
> Clearly, more information is needed. Jonas ?</span >
AFAICS here wl_buffer seems to refer to lowlevel message buffers, not the high
level "image buffer" object exposed in the protocol.
(In reply to Matthias Clasen from <a href="show_bug.cgi?id=767241#c4">comment #4</a>)
<span class="quote">> Looks like a libwayland bug to me.
>
> I think wl_connection_write is missing a loop to deal with size > 4096 in
> chunks.</span >
If I did read the code correctly yesterday, each of those wl_buffer structs
must begin with the object ID, opcode, etc. So effectively a single request
can't be split in chunks.
(In reply to Matthias Clasen from <a href="show_bug.cgi?id=767241#c5">comment #5</a>)
<span class="quote">> Alternatively, the wayland documentation should clearly state that string
> arguments will be limited to 4088 bytes. That probably affects not just the
> title, but also the app id in the xdg-shell protocol.</span >
Agreed about the general lack of documentation, this potentially affects every
request that has variable length fields (strings and arrays basically). Will
bring it up on wayland-devel.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>