<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - tiled (snapped, half-maximized) windows in Wayland aren't GDK_WINDOW_STATE_TILED" href="https://bugzilla.gnome.org/show_bug.cgi?id=766860#c27">Comment # 27</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - tiled (snapped, half-maximized) windows in Wayland aren't GDK_WINDOW_STATE_TILED" href="https://bugzilla.gnome.org/show_bug.cgi?id=766860">bug 766860</a> from <a href="page.cgi?id=describeuser.html&login=simon.mcvittie%40collabora.co.uk" title="Simon McVittie <simon.mcvittie@collabora.co.uk>"> Simon McVittie</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=766860#c25">comment #25</a>) > Review of <a href="attachment.cgi?id=328508&action=diff" name="attach_328508" title="Patch for GTK+">attachment 328508</a> <a href="attachment.cgi?id=328508&action=edit" title="Patch for GTK+">[details]</a> <a href='review?bug=766860&attachment=328508'>[review]</a>: > > Given that this mechanism exists, lets use it. This mechanism doesn't exist until <a href="attachment.cgi?id=328512&action=diff" name="attach_328512" title="Patch for mutter">Attachment #328512</a> <a href="attachment.cgi?id=328512&action=edit" title="Patch for mutter">[details]</a> is (reviewed and) merged. (In reply to Matthias Clasen from <a href="show_bug.cgi?id=766860#c26">comment #26</a>) > Review of <a href="attachment.cgi?id=328512&action=diff" name="attach_328512" title="Patch for mutter">attachment 328512</a> <a href="attachment.cgi?id=328512&action=edit" title="Patch for mutter">[details]</a> <a href='review?bug=766860&attachment=328512'>[review]</a>: > > ::: src/wayland/meta-wayland-xdg-shell.c > @@ +407,3 @@ > + s = wl_array_add (states, sizeof *s); > + *s = XDG_SURFACE_STATE_GNOME_TILED; > + } > > A very obvious enhancement here would be to have separate states for > tiled-left and tiled-right, but we may want to discuss the best way to > encode that; e.g. by enumerating non-tiled edges Having a simple flag for TILED exactly matches the GDK API here, and is sufficient to preserve X11 functionality under Wayland (rectangular window decorations when tiled, and reporting the tiled status to application code). I think there's a risk of letting the perfect be the enemy of the good: can we land the simple version that is sufficient to implement the current GDK API, then leave the bug open (or clone another bug) for enhancing it to describe more elaborate encodings if desired?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>