<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Dragging from fullscreen title to normal mode always places window at the left edge of the screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=764180">bug 764180</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #329688 status</td>
<td>none
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Dragging from fullscreen title to normal mode always places window at the left edge of the screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=764180#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Dragging from fullscreen title to normal mode always places window at the left edge of the screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=764180">bug 764180</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=329688&action=diff" name="attach_329688" title="[PATCH] wayland: Mark pending moved as moved">attachment 329688</a> <a href="attachment.cgi?id=329688&action=edit" title="[PATCH] wayland: Mark pending moved as moved">[details]</a></span> <a href='review?bug=764180&attachment=329688'>[review]</a>:
looks good
::: src/wayland/meta-window-wayland.c
@@ +311,3 @@
if (new_x != window->rect.x || new_y != window->rect.y)
{
+ *result |= META_MOVE_RESIZE_RESULT_MOVED;
At first I was worried because this will make us emit
MetaWindow::position-changed when the window hasn't actually moved yet. But,
consumers of that signal have to query the position anyway so they're still
going to see the old position which shouldn't cause any issues.
Any other solution would have to be updating display->grab_anchor_window_pos
later when we no longer know about the unmaximize() call so we'd need more
state to track it for no added benefit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>